Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Removing unused pubsubSecret from sources.spec #567

Merged
merged 54 commits into from
Feb 26, 2020
Merged

Removing unused pubsubSecret from sources.spec #567

merged 54 commits into from
Feb 26, 2020

Conversation

nachocano
Copy link
Member

Fixes #548

Proposed Changes

  • 🧽 Remove pubSubSecret from the spec of current Sources. This was needed when we had the job-based reconcilers. We do not need it anymore, as we can just use spec.secret for the data plane.
  • 🧽 Added some validations and few other cleanups.

Release Note

The sources do not have a `spec.pubSubSecret` field anymore. If you were setting values there, you can just use `spec.secret` instead.

nachocano and others added 30 commits November 26, 2019 13:19
adding github template for bugs and features
8b1fc6b
renaming
d0b1721
@nachocano
Merge remote-tracking branch 'upstream/master'
906e185
@nachocano
Merge remote-tracking branch 'upstream/master'
671f7d4
Merge remote-tracking branch 'upstream/master'
335ff3f
Merge remote-tracking branch 'upstream/master'
599f281
Merge remote-tracking branch 'upstream/master'
5b2c1d9
Merge remote-tracking branch 'upstream/master'
3e60124
adding comment
e9678ba
Merge remote-tracking branch 'upstream/master'
943916d
Merge remote-tracking branch 'upstream/master'
06194cc
Merge remote-tracking branch 'upstream/master'
3b95c4c
Merge remote-tracking branch 'upstream/master'
e7d1793
@nachocano
Merge branch 'master' of github.com:nachocano/knative-gcp
8b8f3fe
Merge remote-tracking branch 'upstream/master'
27b558a
Merge remote-tracking branch 'upstream/master'
1dcaa69
Merge remote-tracking branch 'upstream/master'
ed4be63
@nachocano
Merge branch 'master' of github.com:nachocano/knative-gcp
ed892c4
@nachocano
nits
b5ee575
@nachocano
nits
91e64fe
Merge remote-tracking branch 'upstream/master'
bd3b21e
Merge remote-tracking branch 'upstream/master'
4312cfd
Merge remote-tracking branch 'upstream/master'
948f834
updating to master
20cc453
missing files
88cc65f
@nachocano
Merge remote-tracking branch 'upstream/master'
631e269
Merge remote-tracking branch 'upstream/master'
f8efe36
Merge remote-tracking branch 'upstream/master'
e296ee0
Merge remote-tracking branch 'upstream/master'
07a46b4
using revision instead of master
d02e685
nachocano and others added 17 commits February 3, 2020 11:11
Merge remote-tracking branch 'upstream/master'
e2f9369
Merge remote-tracking branch 'upstream/master'
678ce7c
@nachocano
Merge branch 'master' of github.com:nachocano/knative-gcp
2222b40
@nachocano
Merge remote-tracking branch 'upstream/master'
ce2f847
@nachocano
Merge remote-tracking branch 'upstream/master'
30ba366
@nachocano
Merge remote-tracking branch 'upstream/master'
e569136
Merge remote-tracking branch 'upstream/master'
7b8676e
Merge remote-tracking branch 'upstream/master'
9c82620
@nachocano
Merge remote-tracking branch 'upstream/master'
4a1f584
Merge remote-tracking branch 'upstream/master'
463a929
Merge remote-tracking branch 'upstream/master'
446f718
Merge remote-tracking branch 'upstream/master'
e6e7820
Merge remote-tracking branch 'upstream/master'
fef14e6
Merge remote-tracking branch 'upstream/master'
439a19e
Merge remote-tracking branch 'upstream/master'
fdeaeba
Merge remote-tracking branch 'upstream/master'
39ef6c2
removing pubsubsecret. Other validation cleanup.
a3830db
@nachocano
Copy link
Member Author

/assign @capri-xiyue

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/pubsub_types.go 6.2% 6.7% 0.4
pkg/apis/events/v1alpha1/cloudauditlogssource_validation.go 83.3% 81.0% -2.4
pkg/apis/events/v1alpha1/cloudpubsubsource_validation.go 88.9% 90.6% 1.7
pkg/apis/events/v1alpha1/cloudschedulersource_validation.go 93.1% 91.7% -1.4
pkg/apis/events/v1alpha1/cloudstoragesource_validation.go 93.5% 92.3% -1.2
pkg/apis/pubsub/v1alpha1/pullsubscription_validation.go 87.5% 88.4% 0.9
pkg/reconciler/pubsub/resources/pullsubscription.go 85.7% 100.0% 14.3

@knative-prow-robot
Copy link
Contributor

@nachocano: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-go-coverage a3830db link /test pull-google-knative-gcp-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@capri-xiyue
Copy link
Contributor

/lgtm

@capri-xiyue
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [capri-xiyue,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 83f9e1c into google:master Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian-mi ian-mi Awaiting requested review from ian-mi

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@capri-xiyue capri-xiyue

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PubSubSecret from Sources
4 participants
@nachocano @knative-metrics-robot @knative-prow-robot @capri-xiyue